Not sure on when i should be part of the attributes here. It is for grant and not for apply. From what I remember when checking out keripy, it seems to auto add i if an exn message is created there.

@iFergal Do you have a link to the lines of code in keripy where this is?

@lenkan Sure - https://github.com/WebOfTrust/keripy/blob/development/src/keri/peer/exchanging.py#L333

I had a look here and it is being done in here as well:

I think this is more explicit, we can amend the interface for the payload parameter in createExchangeMessage to be something like

interface ExchangeMessageData {
   [key: string]: unknown,
   /**
     * The recipient of the message
     */
   i: string
}

that way there is only one way to specify the recipient and we can remove the recipient parameter. This would be more in line with the changes I proposed in #222.

I don't mean to make that change here, but it could be done as a separate PR to tidy up.

Ah I see, though that line of code is never being hit for IPEX since recipient is always passed as undefined to createExchangeMessage. The only other place that createExchangeMessage is called is from the send method of exchanges, which also doesn't pass the recipient.

Maybe @pfeairheller can shed more light on when it should be passed as an attribute too (at least for IPEX).

But agree on the interface tidy up, makes sense to me.

@lenkan We discussed this in the dev call today, and I also can see you have #252 open that also does this. I've pushed the change for the CICD and compose file only to see if it will pass now. Not sure if additionally all of the other changes you have in draft are required too or not with this new version.

cc @rodolfomiranda

Edit - OK, looks like the tests are indeed broken for the new version

@iFergal The changes in aiding.ts is needed for the upgrade. The other changes were only to highlight what is broken.

@lenkan Do you think that PR will merge this week or shall I cherry pick changes to aiding.ts across?

edit - hitting this now, will try to dig into why when I've more time. (on first call to await grantMultisig)

HTTP POST /identifiers/GEDA/ipex/grant - 400 Bad Request - {"title": "400 Bad Request", "description": "attempt to send to unknown AID=EJSc85y7RLnwYDU1BGuVKAY8GKde6zvbEFOgkP-aOEBR"}

I believe that is the exact same error I reproduced in #252. I created the issue in keria that needs resolution WebOfTrust/keria#230. I have not yet debugged keria for that issue.

It would be good to see if it can be reproduced in plain keripy first I think.

I made some other adjustments in my latest push - smids/rmids only changed on group creation, not rotation.

There were also some changes in keripy on not using hard coded salts so our tests can't assume the agent AID anymore.

Once WebOfTrust/keria#243 merges, the only failing test is the one you described for vlei issuance. Haven't got a chance to support on that yet.